Skip to content

fix: Add startupProbe to prevent Superset startup problems #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 2, 2025
Merged

fix: Add startupProbe to prevent Superset startup problems #654

merged 10 commits into from
Sep 2, 2025

Conversation

sbernauer
Copy link
Member

Description

Superset 4.0 and 4.1 both failed to start quick enough on a customer setup on Rhoencloud and crashlooped.
Fixed it via podOverrides, adding the probe to the operator here

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Jul 31, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jul 31, 2025
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 4, 2025
@NickLarsenNZ NickLarsenNZ self-requested a review August 4, 2025 07:50
NickLarsenNZ
NickLarsenNZ requested changes Aug 4, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a changelog suggestion, and question for my own understanding.

@sbernauer sbernauer requested a review from NickLarsenNZ August 4, 2025 11:30
@sbernauer sbernauer mentioned this pull request Aug 15, 2025
Merged
13 tasks
sbernauer
sbernauer commented Aug 21, 2025
View reviewed changes
@sbernauer sbernauer mentioned this pull request Aug 21, 2025
Merged
13 tasks
@sbernauer sbernauer requested review from NickLarsenNZ and removed request for NickLarsenNZ September 1, 2025 07:22
NickLarsenNZ
NickLarsenNZ reviewed Sep 2, 2025
View reviewed changes
NickLarsenNZ
NickLarsenNZ previously approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but left some suggestion for more accurate expect messages.

NickLarsenNZ
NickLarsenNZ previously approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NickLarsenNZ
NickLarsenNZ approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer enabled auto-merge September 2, 2025 14:15
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Sep 2, 2025
@sbernauer sbernauer added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit 7534085 Sep 2, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/startup-probe branch September 2, 2025 14:32
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Sep 8, 2025
@lfrancke
Copy link
Member

lfrancke commented Sep 8, 2025

Please add a release note snippet in the form "Previously, this went wrong. With this release, this was fixed in the following way."

@sbernauer
Copy link
Member Author

sbernauer commented Sep 8, 2025 •
edited by lfrancke
Loading

Release note snippet

Previously, there was a chance containers would not start, because Superset was starting too slow and was killed because of a failing liveness probe. Now, we add a proper startup probe, which allows Superset startup to succeed even if it takes longer.

@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 8, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Sep 8, 2025
@sbernauer sbernauer mentioned this pull request Sep 22, 2025
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@sbernauer sbernauer

Labels
release/25.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bug
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @lfrancke @NickLarsenNZ